Skip to content

fix: run check on interpreter in isolated mode #2738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025

Conversation

mattem
Copy link
Contributor

@mattem mattem commented Apr 5, 2025

Runs the check on the interpreter in the toolchain repo in isolated mode via -I. This ensures it's not influenced by userland environment variables, such as PYTHONPATH which will cause issues if it allows this invocation to use into another interpreter versions site-packages.

@mattem mattem requested review from rickeylev and aignas as code owners April 5, 2025 15:32
@mattem mattem force-pushed the fix/protect_python_invocation branch from 234517c to 62ad8d2 Compare April 5, 2025 15:34
@aignas aignas added this pull request to the merge queue Apr 5, 2025
Merged via the queue into bazel-contrib:main with commit f65b2ac Apr 5, 2025
3 checks passed
@mattem mattem deleted the fix/protect_python_invocation branch April 5, 2025 16:09
github-merge-queue bot pushed a commit that referenced this pull request Apr 9, 2025
Similar to #2738, runs
the call to get the Python interpreter version in isolated mode via
`-I`, ensuring userland Python variables do not affect this call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants