Skip to content

fix: Ensure temporary .pyc & .pyo files are excluded from the interpreters repository files #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2025

Conversation

mattem
Copy link
Contributor

@mattem mattem commented Apr 5, 2025

We've seen cases the temporary versions for the .pyc and .pyo files are unstable on certain interpreter toolchains. The temp files take for form of .pyc.NNN, so the amended glob patten will still match both the .pyc and .pyc.NNN versions of the file names.

@mattem mattem requested review from rickeylev and aignas as code owners April 5, 2025 21:45
Copy link
Collaborator

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah geeze. I swear I had added pyc.NNN ignore stuff to these, too, but I guess not. Thanks!

@rickeylev rickeylev enabled auto-merge April 5, 2025 22:32
@rickeylev rickeylev added this pull request to the merge queue Apr 5, 2025
Merged via the queue into bazel-contrib:main with commit 7f5a1b5 Apr 5, 2025
3 checks passed
@mattem mattem deleted the fix/ignore_tmp_pyco branch April 5, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants