Skip to content

chore: remove unnecessary DEFAULT_BOOTSTRAP_TEMPLATE global #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rickeylev
Copy link
Collaborator

I think the DEFAULT_BOOTSTRAP_TEMPLATE global was used by something in the original
Bazel impl, but now it's just used in one place. Remove the shared global and just
inline the single usage.

@rickeylev rickeylev requested a review from aignas as a code owner April 5, 2025 23:27
@rickeylev rickeylev enabled auto-merge April 5, 2025 23:27
@rickeylev rickeylev force-pushed the chore.rm.default.bootstrap.global branch from 2230d7d to 7a82854 Compare April 5, 2025 23:29
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickeylev rickeylev added this pull request to the merge queue Apr 5, 2025
Merged via the queue into bazel-contrib:main with commit da0e52f Apr 6, 2025
3 checks passed
@rickeylev rickeylev deleted the chore.rm.default.bootstrap.global branch April 9, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants