Skip to content

fix: Prevent absolute path creation in uv lock template #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025

Conversation

asa
Copy link
Contributor

@asa asa commented Apr 10, 2025

This change fixes a bug in the lock rule where, when the package is at the root level, the path to requirements.txt is constructed incorrectly with a leading double slash (//requirements.txt), causing it to be interpreted as an absolute path.

This change detects if the package is empty before constructing the output path.

Work towards #1975

@asa asa requested review from rickeylev and aignas as code owners April 10, 2025 19:48
@aignas aignas enabled auto-merge April 11, 2025 00:29
@aignas aignas added this pull request to the merge queue Apr 11, 2025
Merged via the queue into bazel-contrib:main with commit 6e2d493 Apr 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants