Skip to content

fix(ci): use ubuntu-latest for mypy action #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix(ci): use ubuntu-latest for mypy action #2784

merged 1 commit into from
Apr 17, 2025
+1 −1

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Apr 17, 2025

No description provided.

@aignas aignas requested a review from rickeylev as a code owner April 17, 2025 10:18
groodt
groodt approved these changes Apr 17, 2025
View reviewed changes
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will this risk flakes if the version is pinned to latest? Or should we bump to a static version that works?

@aignas
Copy link
Collaborator Author

aignas commented Apr 17, 2025

I think the risk is low, because mypy action has the necessary pins.

@aignas aignas added this pull request to the merge queue Apr 17, 2025
Merged via the queue into bazel-contrib:main with commit d0950c5 Apr 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groodt groodt groodt approved these changes

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aignas @groodt