packaging/piptool: sort wheels and extras for deterministic output #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Andrew, thanks for the PR. This seems straightforward enough. (Perhaps the sorts should be factored into the Wheel class at some point.) Rebasing, regenerating the par files, and merging... |
brandjon
approved these changes
Mar 4, 2020
30f9d81 to
c72fa2a
Compare
guillaumep
pushed a commit
to guillaumep/rules_python
that referenced
this pull request
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this while updating
gvisorin NixOS (NixOS/nixpkgs#80875); therequirements.bzlfile generated byrules_pythonisn't reproducible, differing based on the filesystem-order-dependent return fromos.walk.This PR is a minimal fix that sorts the repositories in
requirements.bzland the return value fromWheel.extras().