docs/refactor: Use python.defaults, not is_default #2924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are multiple Python toolchains, there are currently two ways of setting the default version: the is_default attribute of python.toolchain() tag class and the python.defaults() tag class. The latter is more powerful, since it also supports files and environment variables. This patch updates the examples, docs and the MODULE.bazel file to use python.defaults(). Relates to pull request bazel-contrib#2588 and issue bazel-contrib#2587.
Apparently changing the top-level MODULE.bazel can break things, so that will keep using is_default for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple Python toolchains, there are currently two ways of setting the default version: the
is_defaultattribute of thepython.toolchain()tag class and thepython.defaults()tag class. The latter is more powerful, since it also supports files and environment variables. This patch updates the examples and the docs to usepython.defaults().Relates to pull request #2588 and issue #2587.