Skip to content

fix: Don't let deprecated test targets get matched by '...' #3045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

fix: Don't let deprecated test targets get matched by '...' #3045

merged 1 commit into from
Jul 2, 2025

Conversation

robinlinden
Copy link
Contributor

@robinlinden robinlinden commented Jul 1, 2025 •
edited by aignas
Loading

This fixes "target '//foo_test' is deprecated: Use 'foo.test' instead. The '*_test' target will be removed in the next major release." being warned about once per compile_pip_requirement call when running bazel test ....

Work towards #2976

@robinlinden
fix: Don't let deprecated test targets get matched by '...'
ce0f15e 
This fixes "target '//foo_test' is deprecated: Use 'foo.test' instead.
The '*_test' target will be removed in the next major release." being
warned about once per `compile_pip_requirement` call when running `bazel
test ...`.
aignas
aignas approved these changes Jul 2, 2025
View reviewed changes
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@aignas aignas added this pull request to the merge queue Jul 2, 2025
Merged via the queue into bazel-contrib:main with commit 4e22d25 Jul 2, 2025
3 checks passed
@robinlinden robinlinden deleted the manual-deprecated-tests branch July 2, 2025 20:08
amartani pushed a commit to benchling/rules_python that referenced this pull request Jul 8, 2025
@robinlinden @amartani
fix: Don't let deprecated test targets get matched by '...' (bazel-co…
ee2dc67 
…ntrib#3045)

This fixes "target '//foo_test' is deprecated: Use 'foo.test' instead.
The '*_test' target will be removed in the next major release." being
warned about once per `compile_pip_requirement` call when running `bazel
test ...`.

Work towards bazel-contrib#2976
@dougthor42 dougthor42 mentioned this pull request Jul 29, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 1, 2025
@dougthor42
chore: Remove aliases in //docs (#3125)
2c53bf6 
Fixes #2976. The rest of it was fixed in #3045.
@dougthor42 dougthor42 mentioned this pull request Aug 4, 2025
Closed
@aignas aignas mentioned this pull request Aug 3, 2025
Closed
4 tasks
@aignas aignas added this to the 1.5.2 milestone Aug 5, 2025
aignas pushed a commit that referenced this pull request Aug 11, 2025
@robinlinden @aignas
fix: Don't let deprecated test targets get matched by '...' (#3045)
ba2e4f8 
This fixes "target '//foo_test' is deprecated: Use 'foo.test' instead.
The '*_test' target will be removed in the next major release." being
warned about once per `compile_pip_requirement` call when running `bazel
test ...`.

Work towards #2976

(cherry picked from commit 4e22d25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aignas aignas aignas approved these changes

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

@groodt groodt Awaiting requested review from groodt groodt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@robinlinden @aignas