fix(local-toolchains): don't watch non-existent include directory #3048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The local_runtime_repo rule was failing on macOS when the Python interpreter's metadata pointed to an include directory that did not exist. This change modifies the rule to check if the include directory exists and is a directory before attempting to watch it with `watch_tree`.
aignas
approved these changes
Jul 4, 2025
rickeylev
added a commit
to rickeylev/rules_python
that referenced
this pull request
Aug 11, 2025
…zel-contrib#3048) Apparently, Macs can mis-report their include directory. Since includes are only needed if C extensions are built, skip watching the directory if it doesn't exist. Work around for bazel-contrib#3043 --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com> (cherry picked from commit be55942)
honglooker
pushed a commit
to honglooker/rules_python
that referenced
this pull request
Aug 13, 2025
…zel-contrib#3048) Apparently, Macs can mis-report their include directory. Since includes are only needed if C extensions are built, skip watching the directory if it doesn't exist. Work around for bazel-contrib#3043 --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
rickeylev
added a commit
that referenced
this pull request
Aug 14, 2025
#3174) fix(local-toolchains): don't watch non-existent include directory (#3048) Apparently, Macs can mis-report their include directory. Since includes are only needed if C extensions are built, skip watching the directory if it doesn't exist. Work around for #3043 --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com> Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, Macs can mis-report their include directory.
Since includes are only needed if C extensions are built, skip watching the directory
if it doesn't exist.
Work around for #3043