Fix entry point discovery on Windows. #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phst
added a commit
to phst/rules_elisp
that referenced
this pull request
Nov 18, 2021
This is required for Windows support.
phst
added a commit
to phst/rules_elisp
that referenced
this pull request
Nov 18, 2021
This reverts commit 7aa3215. Since we don't use entry_points any more, this fix should no longer be needed.
There was a problem hiding this comment.
Can we add a TODO to use zipfile.Path once 3.8 is our minimum supported version? (zipfile.Path is new in 3.8)
It would provide nicer code. Something like:
entry_points_path = zipfile.Path(whl, f"{name}.dist-info/entry_points.txt")
if not entry_points_path.exists():
return dict()
...
Done |
The zipfile module always uses forward slashes, so we shouldn't use os.path.join here.
Co-authored-by: Jonathon Belotti <jonathon@canva.com>
2b825d7 to
89cb6cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zipfile module always uses forward slashes, so we shouldn't use
os.path.join here.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Entry points aren't found on Windows
Issue Number: N/A
What is the new behavior?
Entry points should be found on Windows (haven't fully tested it though)
Does this PR introduce a breaking change?
Other information