Skip to content

Removed examples that are not platform agnostic #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 10, 2022
Merged

Removed examples that are not platform agnostic #620

merged 4 commits into from
Feb 10, 2022

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Feb 8, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

#615 covers the coverage being removed from the examples targets. This change now enables #597 to be merged to fix Windows CI.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

UebelAndre and others added 3 commits February 8, 2022 23:19
Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
@UebelAndre UebelAndre requested a review from f0rmiga February 9, 2022 07:22
@f0rmiga f0rmiga merged commit 46bab13 into bazel-contrib:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants