Skip to content

exec_compatible_with -> target_compatible_with #704 #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

molar
Copy link
Contributor

@molar molar commented Jul 12, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ x ] Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #704

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Not sure if people are relying on the exec_compatible_with also being set.

@google-cla
Copy link

google-cla bot commented Jul 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@molar molar marked this pull request as ready for review July 12, 2022 12:18
@molar molar requested review from brandjon and lberki as code owners July 12, 2022 12:18
@UebelAndre
Copy link
Contributor

cc @groodt would you be able to take a look at this in the near future?

@groodt
Copy link
Collaborator

groodt commented Jul 22, 2022

Will take a look this weekend @UebelAndre

@UebelAndre
Copy link
Contributor

@groodt friendly ping 😄

@groodt groodt self-assigned this Aug 1, 2022
@groodt groodt requested review from groodt and removed request for brandjon and lberki August 1, 2022 10:24
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants