Guard python_interpreter_target workspace name on None type check. #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e an incompatible host python interpreter
mattem
approved these changes
Jul 14, 2022
alexgartner-bc
pushed a commit
to braincorp/rules_python
that referenced
this pull request
Jul 29, 2022
Fixes bazel-contrib#709. Test case for pip imports using "from foo import bar". Test cases for imports of the form "from foo import bar". Remove unnecessary flag (replaced with continue's). Make sure from imports work with std modules. - Add test case with `from __future__ import print_function`. Guard python_interpreter_target workspace name on None type check. (bazel-contrib#755) Fix for requirements_lock with PEP440 direct references (bazel-contrib#756) Fix indentation error. - Make sure that `from foo import bar, baz` works. - Add test case for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #752 which was a bug introduced in a fix for #746
Don't check for the python_interpreter_target workspace name unless it has actually been passed.
PR Checklist
Please check if your PR fulfills the following requirements:
Testing with a host python interpreter is currently not possible because one of the rules_python runtime dependencies expect importlib.resources to be available. importlib.resources was introduced in python3.7 and our buildkite images only have python3.6.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
pip_install without a python_interpreter_target fails as repo exec time.
Issue Number: 752
What is the new behavior?
pip_install without python interpreter configuration works.
Does this PR introduce a breaking change?
Other information