Skip to content

[gazelle] Use filepath.WalkDir instead of filepath.Walk #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2022
Merged

[gazelle] Use filepath.WalkDir instead of filepath.Walk #770

merged 1 commit into from
Jul 28, 2022

Conversation

dzbarsky
Copy link
Contributor

filepath.WalkDir lets us avoid calling stat on each file.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

N/A

What is the new behavior?

Avoid a stat call for each file and slightly cleaner error handling

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@dzbarsky dzbarsky requested a review from f0rmiga as a code owner July 27, 2022 23:39
f0rmiga
f0rmiga approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@f0rmiga f0rmiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! When I wrote this code, go 1.16 didn't exist yet (or had just been released). I guess it's pretty safe to use it now.

Could you add to the docs that Go 1.16+ is required, please?

@f0rmiga f0rmiga merged commit d278223 into bazel-contrib:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f0rmiga f0rmiga f0rmiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzbarsky @f0rmiga