Skip to content

Simplify glob pattern to exclude static libraries #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tetsuok
Copy link
Contributor

@tetsuok tetsuok commented Jul 29, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Applies @f0rmiga's suggestion to simplify glob pattern to exclude static libraries from the hermetic Python toolchain.

@tetsuok tetsuok requested review from brandjon and lberki as code owners July 29, 2022 00:26
@groodt groodt force-pushed the simplify-glob-pattern-to-remove-static-libs branch from c78483a to a2cea3c Compare August 1, 2022 11:37
@groodt groodt merged commit 73e2490 into bazel-contrib:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants