Exclude unused libpython{python_version}.so to reduce the size of zipped Python executables #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
#758 reduced the size of artifacts built by the
bazel build
command with the--build_python_zip
option, but there is still room for improvement. The size of the artifacts is at least 43MB (e.g., a zipped python binary which just prints "hello, world"). This is still not great when build artifacts are included to docker images. It turned out that the --build_python_zip option includes the two identical shared libraries (not symlinks),libpython{python_version}.so
andlibpython{python_version}.so.1.0
into the zip files, but rules_python doesn't uselibpython{python_version}.so
.libpython{python_version}.so
occupies 16MB (37% of the total size of the artifact of size 43MB). By removing the unused shared library, users of rules_python can deploy smaller Python binaries.Repro steps
WORKSPACE
:BUILD
:hello.py
:You can see two identical shared libraries,
libpython{python_version}.so
andlibpython{python_version}.so.1.0
into zip files, and the shared libraries dominate the total size of zip files:What is the new behavior?
The unused shared library,
libpython{python_version}.so
included in the hermetic Python toolchain is excluded from Python runfiles built by Python rules. Artifacts built by thebazel build
command with the--build_python_zip
get smaller. The size of the resulting zipped Python executables reduces by 16 MB (43 MB → 27 MB in the above example).Does this PR introduce a breaking change?
Other information