chore: remove pkginfo from bzlmod file #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under bazel 5 this unused entry is okay, but with Bazel 6 you get an error ERROR: Analysis of target '//:bzlmod' failed; build aborted: module extension "pip_install" from "@@rules_python~override//python:extensions.bzl" does not generate repository "pypi__pkginfo", yet it is imported as "pypi__pkginfo" in the usage at rules_python@_/MODULE.bazel:7:28 This was detected on BCR which runs against latest bazel, so I had to make this change there already: bazelbuild/bazel-central-registry@6e1bf0e#diff-d133485c86e1650c9910643274be2051f2c714042c59de22b4c3fd6e546bd93c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under bazel 5 this unused entry is okay, but with Bazel 6 you get an error
ERROR: Analysis of target '//:bzlmod' failed; build aborted: module extension "pip_install" from "@@rules_python~override//python:extensions.bzl" does not generate repository "pypi__pkginfo", yet it is imported as "pypi__pkginfo" in the usage at rules_python@_/MODULE.bazel:7:28
This was detected on BCR which runs against latest bazel, so I had to
make this change there already:
bazelbuild/bazel-central-registry@6e1bf0e#diff-d133485c86e1650c9910643274be2051f2c714042c59de22b4c3fd6e546bd93c