Added importlib + reqs to pip-compile for python < 3.8 #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattem
reviewed
Aug 10, 2022
Comment on lines
+79
to
+81
| requirement("importlib_metadata"), | ||
| requirement("zipp"), | ||
| requirement("more_itertools"), |
There was a problem hiding this comment.
Are these all noops in higher language version? I know import_metadata is. I'm surprised this still works with versions like 3.6 given the version of pip-tools used here is now incompatible with that version.
There was a problem hiding this comment.
I can't speak for 3.6, but this rule definitely doesn't work for 3.7, which is the version we're trying to work with. Far as I can see, the other two aren't nops, but they should be compatible with the relevant interfaces.
There was a problem hiding this comment.
Yeah I guess we've dropped 3.6 support here given it's EoL, so that's fine. Thanks for checking!
mattem
approved these changes
Aug 10, 2022
dd546e5 to
e506ec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
You cannot run the
compile_pip_requirements.updatetarget with a Python interpreter at a version < 3.8 - it will fail on importingimportlib_metadatain thebuildpackageWhat is the new behavior?
You can run the
compile_pip_requirements.updatetarget with a Python interpreter at a version < 3.8Does this PR introduce a breaking change?
Other information
I could see a scenario where part of the setup instructions involve telling the user to produce a lockfile for
pip-compilefrom their local env, but it's probably just easier to package up all the reqs for any version.