Skip to content

Add a consistent python interpreter symlink #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

mattyclarkson
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The python repository interpreter target is different for each platform

Issue Number: N/A

What is the new behavior?

Adds a consitent :python target that symlinks to the interpreter.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

When a Python repository is created, there is a difference between Unix/Windows for the path to the python interpreter.

This patch adds a symlink from the platform specific path to the interpreter.

This means that on either platform the `:python` target will always point to the interpreter.
Copy link
Contributor

@mattem mattem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@mattem mattem merged commit e69c2ae into bazel-contrib:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants