Skip to content

Ran black and isort to fix files missed by commit hook #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2022
Merged

Ran black and isort to fix files missed by commit hook #790

merged 1 commit into from
Aug 14, 2022

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Aug 13, 2022 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #509 (related but this PR does not close this)

It seems not all contributors have commit hooks setup. This change was caught when I tried to make a separate change.

What is the new behavior?

This change is only formatting.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@UebelAndre UebelAndre marked this pull request as ready for review August 13, 2022 21:02
@groodt groodt self-assigned this Aug 14, 2022
groodt
groodt approved these changes Aug 14, 2022
View reviewed changes
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@groodt groodt merged commit d7ae311 into bazel-contrib:main Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groodt groodt groodt approved these changes

@f0rmiga f0rmiga Awaiting requested review from f0rmiga

@brandjon brandjon Awaiting requested review from brandjon

@lberki lberki Awaiting requested review from lberki

@thundergolfer thundergolfer Awaiting requested review from thundergolfer

Assignees

@groodt groodt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @groodt