Skip to content

Revert "pip_compile: remove external/workspace_name prefix from gener… #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 27, 2022
Merged

Revert "pip_compile: remove external/workspace_name prefix from gener… #794

merged 6 commits into from
Aug 27, 2022

Conversation

alexeagle
Copy link
Contributor

…ated requirements.txt (#690)"

This reverts commit aef17ad.

Fixes #766

@alexeagle alexeagle force-pushed the revert_690 branch 2 times, most recently from 29a1607 to cf4ef3d Compare August 17, 2022 00:19
@alexeagle alexeagle requested a review from groodt August 17, 2022 01:00
@hrfuller
Copy link
Contributor

hrfuller commented Aug 18, 2022 •
edited
Loading

I know we decided this kind of drive-by change doesn't follow our principles for evolving the project, and makes the code that much harder to read, but just curious were there any known breakages caused by this? Just saw the linked ticket.

groodt
groodt approved these changes Aug 27, 2022
View reviewed changes
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@groodt groodt merged commit edfd9f4 into main Aug 27, 2022
@groodt groodt deleted the revert_690 branch August 27, 2022 22:07
Ghjkvvgj
Ghjkvvgj reviewed Nov 3, 2022
View reviewed changes
Copy link

@Ghjkvvgj Ghjkvvgj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y

Ghjkvvgj
Ghjkvvgj reviewed Nov 3, 2022
View reviewed changes
Copy link

@Ghjkvvgj Ghjkvvgj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghjkvvgj Ghjkvvgj Ghjkvvgj left review comments

@groodt groodt groodt approved these changes

@hrfuller hrfuller hrfuller approved these changes

@brandjon brandjon Awaiting requested review from brandjon

@lberki lberki Awaiting requested review from lberki

@thundergolfer thundergolfer Awaiting requested review from thundergolfer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local relative requirements compile fails under 0.10.0+
4 participants
@alexeagle @hrfuller @groodt @Ghjkvvgj