Skip to content

Disable `//python/tests/toolchains:python_3_8_10_x86_64-apple-darwin_… #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2022
Merged

Disable `//python/tests/toolchains:python_3_8_10_x86_64-apple-darwin_… #830

merged 2 commits into from
Sep 16, 2022

Conversation

meteorcloudy
Copy link
Contributor

@meteorcloudy meteorcloudy commented Sep 16, 2022 •
edited
Loading

…test`

See #827

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@meteorcloudy meteorcloudy requested a review from groodt September 16, 2022 12:57
groodt
groodt approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@groodt groodt merged commit a364fca into main Sep 16, 2022
@groodt groodt deleted the meteorcloudy-patch-1 branch September 16, 2022 13:02
fishcakez added a commit to fishcakez/rules_python that referenced this pull request Sep 21, 2022
@fishcakez
Revert "Disable `//python/tests/toolchains:python_3_8_10_x86_64-apple…
1e0247f 
…-darwin_… (bazel-contrib#830)"

This reverts commit a364fca.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groodt groodt groodt approved these changes

@thundergolfer thundergolfer Awaiting requested review from thundergolfer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorcloudy @groodt