-
-
Notifications
You must be signed in to change notification settings - Fork 590
chore: publish a runfiles library as a wheel #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like our buildifier presubmit check is broken, it complains about
|
Wire it up to GH actions so it is published for each release. Tested locally with: bazel build python/runfiles:wheel --embed_label=1.0.2 --stamp PYTHONPATH=bazel-bin/python/runfiles/bazel_runfiles-_BUILD_EMBED_LABEL_-py3-none-any.whl python >>> import runfiles >>> runfiles.Create() Note, I would have liked to call the package bazel-runfiles, but this isn't possible without either refactoring the paths in this repo, or doing some fancy starlark to copy files around to create a folder that we turn into the wheel. There is no project https://pypi.org/project/runfiles though there is a https://pypi.org/project/runfile We could try harder to get the name we prefer.
It's broken because the new buildifier release formats |
Yeah, I rebased over a commit I added on |
The logic in |
Yeah I'll try adding the integration test before merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM.
+1 to having some sort of test; I'm ok with that being a separate change though, too
Co-authored-by: Richard Levasseur <richardlev@gmail.com>
@rickeylev looks like your personal email isn't properly connected with your GitHub identity in a way that Google's CLA bot understands - this is the result of applying your suggestions. You might need to add that email address in http://go/github ? |
CLA issue fixed |
Cool, thanks! |
our 0.17 release is stuck on this step. Partially reverts #995
our 0.17 release is stuck on this step. Partially reverts #995
Wire it up to GH actions so it is published for each release.
Tested locally with:
Note, I would have liked to call the package bazel-runfiles, but this isn't possible without either refactoring the paths in this repo, or doing some fancy starlark to copy files around to create a folder that we turn into the wheel. There is no project https://pypi.org/project/runfiles though there is a https://pypi.org/project/runfile
We could try harder to get the name we prefer.