Skip to content

Conversation

tjdwill
Copy link
Contributor

@tjdwill tjdwill commented Mar 27, 2024

  • Fixed code example bugs (~ Ln. 214 and ~Ln. 614)
    • T was not defined;
    • quat.qqmul -> qqmul
  • Clarified sentence at Ln. 156.

- Fixed code example bugs (~ Ln. 214 and ~Ln. 614)
  - ``T`` was not defined; 
  - ``quat.qqmul`` -> ``qqmul``
- Clarified sentence at Ln. 156.
@jcao-bdai
Copy link
Collaborator

@tjdwill thank you for creating this PR, i just started the workflow to unit-test it.

sorry for the late response, too! somehow i did not get any notification from this new PR, will need to fix my settings.

1 similar comment
@jcao-bdai
Copy link
Collaborator

@tjdwill thank you for creating this PR, i just started the workflow to unit-test it.

sorry for the late response, too! somehow i did not get any notification from this new PR, will need to fix my settings.

Copy link
Collaborator

@jcao-bdai jcao-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@tjdwill
Copy link
Contributor Author

tjdwill commented Apr 17, 2024

Thank you so much!

@jcao-bdai jcao-bdai merged commit b16b34f into bdaiinstitute:master Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants