Skip to content

Include smartport telemetry for Fport #12314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

Include smartport telemetry for Fport #12314

merged 1 commit into from
Feb 6, 2023

Conversation

klutvott123
Copy link
Member

Fport should include working telemetry when selected as serial rx protocol. It's not obvious for the user that smartport telemetry has to be selected to get telemetry working for fport.

The documentation also suggests that telemetry should be included during the build for Fport http://betaflight.com/docs/development/API/Cloud-Build-API#telemetry-protocols

@github-actions

This comment has been minimized.

Sign in to view
@klutvott123 klutvott123 mentioned this pull request Feb 5, 2023
Closed
@haslinghuis haslinghuis added this to the 4.5 milestone Feb 5, 2023
@blckmn
Copy link
Member

blckmn commented Feb 6, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

blckmn
blckmn requested changes Feb 6, 2023
View reviewed changes
@klutvott123 klutvott123 force-pushed the fport-include-smartport branch from 6bfc4f8 to 1d65b2f Compare February 6, 2023 11:22
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn blckmn merged commit facf44b into betaflight:master Feb 6, 2023
@McGiverGim McGiverGim mentioned this pull request Feb 7, 2023
Closed
@klutvott123 klutvott123 deleted the fport-include-smartport branch February 15, 2023 12:43
klutvott123 added a commit to klutvott123/betaflight that referenced this pull request Mar 25, 2023
@klutvott123
Include smartport telemetry for Fport (betaflight#12314)
fa632e8
@klutvott123 klutvott123 mentioned this pull request Mar 25, 2023
Merged
haslinghuis pushed a commit that referenced this pull request Mar 26, 2023
@klutvott123
4.4.1 Include smartport telemetry for Fport (#12314) (#12572)
2c72265 
Include smartport telemetry for Fport (#12314)
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@klutvott123 @davidbitton
Include smartport telemetry for Fport (betaflight#12314)
983da79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@klutvott123 klutvott123

Labels
Cleanup
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
4 participants
@klutvott123 @blckmn @McGiverGim @haslinghuis