Add rainbow effect to led strip #12323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

haslinghuis merged 3 commits into betaflight:master from ASDosjani:rainbow

Mar 16, 2023

Contributor

ASDosjani commented Feb 6, 2023 •

edited

Loading

This PR adds rainbow effect to the led strip overlays, based on #6840.

Configurator changes: #3322

For testing please use cloud building.

This comment has been minimized.

Sign in to view

ASDosjani mentioned this pull request

Add rainbow effect to led strip and cleanup betaflight/betaflight-configurator#3322

Merged

Member

blckmn commented Feb 6, 2023 •

edited

Loading

AUTOMERGE: (FAIL)

github identifies PR as mergeable -> PASS
assigned to a milestone -> PASS
cooling off period lapsed -> PASS
commit count less or equal to three -> PASS
Don't merge label NOT found -> PASS
at least one RN: label found -> PASS
Tested label found -> FAIL
assigned to an approver -> FAIL
approver count at least three -> PASS

ASDosjani force-pushed the rainbow branch from 7beccd0 to d723c12 Compare

February 7, 2023 09:34

This comment has been minimized.

Sign in to view

ASDosjani force-pushed the rainbow branch from a196ddb to bfe3ebc Compare

February 7, 2023 10:09

This comment has been minimized.

Sign in to view

sugaarK added Testing Required RN: MINOR FEATURE labels

sugaarK added this to the 4.5 milestone

ASDosjani force-pushed the rainbow branch from bfe3ebc to 5dae97b Compare

February 9, 2023 12:13

This comment has been minimized.

Sign in to view

ASDosjani force-pushed the rainbow branch from 5dae97b to fef6825 Compare

February 11, 2023 09:46

This comment has been minimized.

Sign in to view

ASDosjani force-pushed the rainbow branch from fef6825 to 655498a Compare

February 11, 2023 16:56

This comment has been minimized.

Sign in to view

ASDosjani force-pushed the rainbow branch from 655498a to 788b81a Compare

February 15, 2023 10:58

This comment has been minimized.

Sign in to view

betaflight-admin commented Feb 15, 2023

ASDosjani#8597 (Discord) commented:
test comment

Member

freasy commented Feb 16, 2023

un!t#6860 (Discord) commented:
test from un!t

Member

freasy commented Feb 16, 2023

un!t#6860 (Discord) commented:
last test, sorry!

ASDosjani force-pushed the rainbow branch from 788b81a to 8bba150 Compare

February 17, 2023 00:08

This comment has been minimized.

Sign in to view

betaflight-admin commented Feb 17, 2023

un!t#6860 (Discord) commented:
Tested with provided hex and configurator build.
Working as expected.

betaflight-admin commented Feb 18, 2023

sugar K#0936 (Discord) commented:
tested works real nice

ASDosjani force-pushed the rainbow branch from 8bba150 to 2b1e87a Compare

February 25, 2023 12:32

This comment has been minimized.

Sign in to view

ASDosjani force-pushed the rainbow branch from 2b1e87a to 1fa81b8 Compare

February 28, 2023 11:05

This comment has been minimized.

Sign in to view

haslinghuis added the Tests failing label

haslinghuis assigned ASDosjani

ASDosjani force-pushed the rainbow branch from 1fa81b8 to 3751876 Compare

February 28, 2023 23:44

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Member

haslinghuis commented Mar 1, 2023

We need to increment PG version (io/ledstrip.c):

PG_REGISTER_WITH_RESET_FN(ledStripConfig_t, ledStripConfig, PG_LED_STRIP_CONFIG, 2);

Member

haslinghuis commented Mar 1, 2023

@TheIsotopes are you able to test?

Contributor Author

ASDosjani commented Mar 1, 2023

Should I just increment 2 to 3?
Can you make a code suggestion?

Contributor

TheIsotopes commented Mar 1, 2023

are you able to test?

@haslinghuis imo all looks good
Larson Scanner with rainbow effect ... I think it works as it should.

currently there is still a problem with a default value:

# get ledstrip_rainbow_freq
ledstrip_rainbow_freq = 75
Allowed range: 1 - 200
Default value: 0
###ERROR IN get: CORRUPTED CONFIG: ledstrip_rainbow_freq = 0###

haslinghuis requested changes

View reviewed changes

src/main/io/ledstrip.h

Comment on lines +186 to +187

		uint8_t ledstrip_rainbow_delta;
		uint8_t ledstrip_rainbow_freq;

Member

haslinghuis Mar 1, 2023

Add and initialize in io/ledstrip.c in pgResetFn_ledStripConfig``

Contributor Author

ASDosjani Mar 1, 2023

Done, thanks, I didn't know how to set up default values.

ASDosjani added 3 commits

March 1, 2023 20:51


          Add rainbow effect

a342606


          unit test

aea8164


          default values + version change

a3c9b9b

ASDosjani force-pushed the rainbow branch from b6ba629 to a3c9b9b Compare

March 1, 2023 20:05

github-actions bot commented Mar 1, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

ASDosjani requested a review from haslinghuis

March 1, 2023 21:14

Member

haslinghuis commented Mar 1, 2023

@TheIsotopes should be fixed now.

Contributor

TheIsotopes commented Mar 1, 2023

@haslinghuis it's fixed.

haslinghuis approved these changes

View reviewed changes

haslinghuis removed Testing Required Tests failing labels

blckmn approved these changes

View reviewed changes

haslinghuis added the Ready to Merge label

sugaarK approved these changes

View reviewed changes

haslinghuis added the Needs coordination with betaflight-configurator label

haslinghuis merged commit 7735a71 into betaflight:master

davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request


          Add rainbow effect to led strip (betaflight#12323)

17f4cae

* Add rainbow effect

* unit test

* default values + version change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs coordination with betaflight-configurator Ready to Merge RN: MINOR FEATURE