Skip to content

AT32F435 BlackBox FLASH support #12431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2023
Merged

AT32F435 BlackBox FLASH support #12431

merged 1 commit into from
Mar 5, 2023

Conversation

SteveCEvans
Copy link
Member

Merge after #12423 and #12429.

USB MSC support is not yet added so download logs using
image

@SteveCEvans SteveCEvans self-assigned this Feb 27, 2023
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Feb 27, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@haslinghuis haslinghuis added this to the 4.5 milestone Feb 27, 2023
@haslinghuis
Copy link
Member

Something is wrong with STM32H723 target?

@github-actions

This comment has been minimized.

Sign in to view
@SteveCEvans
Copy link
Member Author

Something is wrong with STM32H723 target?

Sorry about that. Fixed.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
haslinghuis
haslinghuis reviewed Mar 5, 2023
View reviewed changes
src/main/drivers/at32/bus_spi_at32bsp.c Outdated
Comment on lines 364 to 367
bus->busType_u.spi.instance,
bus->curSegment->u.buffers.txData,
bus->curSegment->u.buffers.rxData,
bus->curSegment->len
);
bus->curSegment->len);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully you're happier with how it looks now.

@github-actions
Copy link

github-actions bot commented Mar 5, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@haslinghuis haslinghuis merged commit ab2088d into betaflight:master Mar 5, 2023
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@SteveCEvans @davidbitton
AT32F435 BlackBox FLASH support (betaflight#12431)
c8d9bca 
Add FLASH support to AT32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@klutvott123 klutvott123 Awaiting requested review from klutvott123

@blckmn blckmn Awaiting requested review from blckmn

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

Assignees

@SteveCEvans SteveCEvans

Labels
RN: IMPROVEMENT RN: TARGET UPDATE
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
4 participants
@SteveCEvans @blckmn @haslinghuis @KarateBrot