Skip to content

Rename MOSI and MISO to SDO and SDI #12469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2023
Merged

Rename MOSI and MISO to SDO and SDI #12469

merged 1 commit into from
Mar 7, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Mar 7, 2023 •
edited
Loading

This is not about Master and Slave but SDO / SDI is easier to read and inline with SDIO

image

Term Description Deprecated
SDO Serial Data Out Master Out Slave In (MOSI)
SDI Serial Data In Master In Slave Out (MISO)

https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names/

We don't seem to use PICO and POCI 😃

@haslinghuis haslinghuis added this to the 4.5 milestone Mar 7, 2023
@haslinghuis haslinghuis self-assigned this Mar 7, 2023
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the rename-mosi-miso branch 2 times, most recently from 8a8a8f5 to 8870edf Compare March 7, 2023 01:31
@haslinghuis haslinghuis requested review from blckmn, SteveCEvans, KarateBrot and klutvott123 and removed request for blckmn March 7, 2023 01:37
@haslinghuis haslinghuis force-pushed the rename-mosi-miso branch 3 times, most recently from 93dd6ef to bab77af Compare March 7, 2023 02:01
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the rename-mosi-miso branch 2 times, most recently from da73e36 to 279b720 Compare March 7, 2023 02:23
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Mar 7, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@haslinghuis haslinghuis requested a review from sugaarK March 7, 2023 12:38
@blckmn blckmn merged commit ee2ee56 into betaflight:master Mar 7, 2023
@haslinghuis haslinghuis deleted the rename-mosi-miso branch March 7, 2023 17:44
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
Rename MOSI and MISO to SDO and SDI (betaflight#12469)
2f31566 
Rename MOSI/MISO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@SteveCEvans SteveCEvans SteveCEvans approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@klutvott123 klutvott123 Awaiting requested review from klutvott123

@sugaarK sugaarK Awaiting requested review from sugaarK

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: REFACTORING
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @blckmn @SteveCEvans @KarateBrot