Fix buffer overflow in JETIEXBUS character reception #13130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to test this code? You can flash it directly from Betaflight Configurator:
WARNING: It may be unstable. Use only for testing! |
blckmn
approved these changes
Oct 21, 2023
1117aa9 to
361d5d8
Compare
|
AUTOMERGE: (FAIL)
|
This was referenced Oct 21, 2023
klutvott123
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Thanks @SteveCEvans 👍
My test setup has been running this for a few hours now with no freeze
haslinghuis
approved these changes
Oct 21, 2023
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
haslinghuis
added a commit
to haslinghuis/betaflight
that referenced
this pull request
Oct 23, 2023
* Fix buffer overflow in jetiexbus character reception * Update src/main/rx/jetiexbus.c Co-authored-by: Mark Haslinghuis <mark@numloq.nl> --------- Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
haslinghuis
added a commit
that referenced
this pull request
Oct 23, 2023
davidbitton
pushed a commit
to davidbitton/betaflight
that referenced
this pull request
Feb 5, 2024
* Fix buffer overflow in jetiexbus character reception * Update src/main/rx/jetiexbus.c Co-authored-by: Mark Haslinghuis <mark@numloq.nl> --------- Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a buffer overflow that resulted in an FC hang.
Fixes #12756
Credit to @klutvott123 for determining how to reliably reproduce this issue using the python script below to send a serial data stream to an FC using an FTDI serial adaptor, connecting the FTDI TX line to the FC TX line via a 1K resistor.
jetiexbus_test.py.zip