Skip to content

Fix BMI160 gate, improve MPU6500 initialization and optimize directives for maintenance #13237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 31, 2023
Merged

Fix BMI160 gate, improve MPU6500 initialization and optimize directives for maintenance #13237

merged 3 commits into from
Dec 31, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 21, 2023 •
edited
Loading

@haslinghuis haslinghuis added this to the 4.5 milestone Dec 21, 2023
@haslinghuis haslinghuis self-assigned this Dec 21, 2023
@github-actions GitHub Actions
Copy link

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #13237 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@haslinghuis haslinghuis changed the title Add BMI160 gate and other defines Add BMI160 gate and other directives Dec 21, 2023
@blckmn
Copy link
Member

blckmn commented Dec 21, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@haslinghuis haslinghuis changed the title Add BMI160 gate and other directives Fix BMI160 gate and other directives Dec 21, 2023
@KarateBrot
Copy link
Member

I don't think you need the directives for the header files of the drivers. The implementation (in the .c files) is gated already.

@haslinghuis haslinghuis force-pushed the add-missing-accgyro-gate branch 2 times, most recently from e5e17e0 to 06d3f96 Compare December 22, 2023 07:02
@haslinghuis haslinghuis force-pushed the add-missing-accgyro-gate branch from 06d3f96 to 4edca26 Compare December 22, 2023 07:42
@haslinghuis haslinghuis changed the title Fix BMI160 gate and other directives Fix BMI160 gate and optimize directives Dec 22, 2023
nerdCopter
nerdCopter approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving untested

@haslinghuis haslinghuis merged commit 2ee519e into betaflight:master Dec 31, 2023
@haslinghuis haslinghuis deleted the add-missing-accgyro-gate branch December 31, 2023 22:37
@haslinghuis haslinghuis changed the title Fix BMI160 gate and optimize directives Fix BMI160 gate, improve MPU6500 initialization and optimize directives for maintenance Dec 31, 2023
freasy pushed a commit to freasy/betaflight that referenced this pull request Jan 22, 2024
@haslinghuis
Fix BMI160 gate and optimize directives (betaflight#13237)
1c1f99e 
* Add BMI160 gate and other defines

* Fix make test

* Remove redundant directives
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
Fix BMI160 gate and optimize directives (betaflight#13237)
cdb6ea9 
* Add BMI160 gate and other defines

* Fix make test

* Remove redundant directives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@ledvinap ledvinap Awaiting requested review from ledvinap

@SteveCEvans SteveCEvans Awaiting requested review from SteveCEvans

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

Assignees

@haslinghuis haslinghuis

Labels
Cleanup RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @blckmn @KarateBrot @nerdCopter