Skip to content

Fix missing GPS PG parameter #13248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix missing GPS PG parameter #13248

merged 1 commit into from
Jan 4, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 27, 2023 •
edited
Loading

Will need a rebase after #13244 to increase PG version to 4 again.

EDIT: done.

@haslinghuis haslinghuis added this to the 4.5 milestone Dec 27, 2023
@haslinghuis haslinghuis self-assigned this Dec 27, 2023
@github-actions GitHub Actions
Copy link

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #13248 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@haslinghuis haslinghuis force-pushed the fix-missing-gps-pg-parameter branch from bb6376e to c7f9801 Compare December 27, 2023 15:27
@blckmn
Copy link
Member

blckmn commented Dec 27, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@haslinghuis haslinghuis force-pushed the fix-missing-gps-pg-parameter branch from c7f9801 to 9b1be79 Compare December 27, 2023 21:20
@haslinghuis haslinghuis force-pushed the fix-missing-gps-pg-parameter branch from 9b1be79 to 667aafe Compare December 28, 2023 00:52
@ctzsnooze
Copy link
Member

@blckmn if this was approved, would we need to bump the EEPROM number, to force Full Chip Erase, or is a change of this kind just setting a default, and not modifying the structure of the flash space assigned to a configuration?

@haslinghuis haslinghuis merged commit 7cb07d8 into betaflight:master Jan 4, 2024
@haslinghuis haslinghuis deleted the fix-missing-gps-pg-parameter branch January 4, 2024 14:19
freasy pushed a commit to freasy/betaflight that referenced this pull request Jan 22, 2024
@haslinghuis
Fix missing GPS PG parameter (betaflight#13248)
6541845
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
Fix missing GPS PG parameter (betaflight#13248)
6a3b29e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @blckmn @ctzsnooze @KarateBrot @nerdCopter