Add resource for LPUART #13306

haslinghuis · 2024-01-17T20:03:22Z

LPUART is not an usual U[S]ART port: https://www.st.com/resource/en/application_note/an4635-minimization-of-power-consumption-using-lpuart-for-stm32-microcontrollers-stmicroelectronics.pdf
Never had to use softserial but in 4.4 it used UART11 and UART12 before as now we need UART 11 to define LPUART1.
In config [repo] we use LPUART pins to define a serial port with LPUART1.
Currently in CLI we need to use SERIAL 11 to configure LPUART port which is [treated] different from a normal U[S]ART.
This PR follows configuration in config.h and allows CLI to use resource LPUART instead but uses same UART constructs.
This PR prevents configuring UART 11 to be used as LPUART while there is no LPUART resource available.

# resource
resource SERIAL_TX 1 A09
resource SERIAL_TX 2 B03
resource SERIAL_TX 4 C10
resource SERIAL_RX 1 A10
resource SERIAL_RX 2 B04
resource SERIAL_RX 3 B09
resource SERIAL_RX 4 C11
resource LPUART_TX 1 A09
resource LPUART_RX 1 A10

# serial
serial 20 1 115200 57600 0 115200
serial 0 0 115200 57600 0 115200
serial 1 0 115200 57600 0 115200
serial 2 0 115200 57600 0 115200
serial 3 0 115200 57600 0 115200
serial 40 0 115200 57600 0 115200

In documentation we have

ID's 0-19 reserved for UARTS 1-20 
ID's 20-29 reserved for USB 1-10
ID's 30-39 reserved for SoftSerial 1-10
ID's 40-49 reserved for LPUART 1-10
Other devices can be added starting from id 50.

There is an issue when assigning UART 11 on KAKUTEH7MINI we get - as there is no LPUART here:

github-actions · 2024-01-17T20:03:34Z

Do you want to test this code? You can flash it directly from Betaflight Configurator:

Simply put #13306 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

ctzsnooze · 2024-01-18T02:17:43Z

I think it would definitely be good to categorise LPUART separately in RESOURCES.

I would approve this PR if it is technically the right way to do it.

github-actions · 2024-02-17T04:31:53Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

HThuren · 2024-02-18T12:16:19Z

Are we sure no more need for more LPUART ports, maybe give room for more than 1 new port ie.

ID's 40-54 reserved for LPUART 1-15
Other devices can be added starting from id 55.

I think an update of documentation are important.

haslinghuis · 2024-02-19T23:39:11Z

Our current targets do not have a second LPUART port. If needed it can be extended.

HThuren · 2024-02-20T06:33:16Z

Our current targets do not have a second LPUART port. If needed it can be extended.

yes, of course, but then also documentation etc etc, but no big issue .-)

ledvinap · 2024-02-26T13:50:42Z

src/main/cli/cli.c

-    DEFA( OWNER_SERIAL_TX,     PG_SERIAL_PIN_CONFIG, serialPinConfig_t, ioTagTx[0], SERIAL_PORT_MAX_INDEX ),
-    DEFA( OWNER_SERIAL_RX,     PG_SERIAL_PIN_CONFIG, serialPinConfig_t, ioTagRx[0], SERIAL_PORT_MAX_INDEX ),
+    DEFA( OWNER_SERIAL_TX,     PG_SERIAL_PIN_CONFIG, serialPinConfig_t, ioTagTx[0], SERIAL_PORT_MAX_INDEX - SERIAL_LPUART_MAX_INDEX),
+    DEFA( OWNER_SERIAL_RX,     PG_SERIAL_PIN_CONFIG, serialPinConfig_t, ioTagRx[0], SERIAL_PORT_MAX_INDEX - SERIAL_LPUART_MAX_INDEX),


Isn't it better to define serialPinConfig_t { ioTagTx[SERIAL_PORT_MAX_INDEX + SERIAL_LPUART_MAX_INDEX]; ... }

Subtracting SERIAL_LPUART_MAX_INDEX (1) from SERIAL_PORT_MAX_INDEX (11) to have 10 UARTs and 1 LPUART.

But you must change both, or it will break.

But a lot of hardwired problems will surface if you change it, so keeping change minimal may be better

src/main/cli/cli.c

ledvinap · 2024-02-26T16:03:37Z

src/main/cli/cli.c

+#endif
+#ifdef USE_LPUART1
+    DEFA( OWNER_LPUART_TX,     PG_SERIAL_PIN_CONFIG, serialPinConfig_t, ioTagTx[SERIAL_PORT_MAX_INDEX], SERIAL_LPUART_MAX_INDEX ),
+    DEFA( OWNER_LPUART_TX,     PG_SERIAL_PIN_CONFIG, serialPinConfig_t, ioTagRx[SERIAL_PORT_MAX_INDEX], SERIAL_LPUART_MAX_INDEX ),


no inverter for LPUART?

Yes was not sure - reverted

ledvinap · 2024-02-26T16:05:06Z

src/main/drivers/resource.c

@@ -113,4 +113,6 @@ const char * const ownerNames[OWNER_TOTAL_COUNT] = {
    "RX_SPI_EXPRESSLRS_BUSY",
    "SOFTSERIAL_TX",
    "SOFTSERIAL_RX",
+    "LPUART_TX",


(maybe refactor all lines into designated initializers:

Suggested change

"LPUART_TX",

[OWNER_LPUART_TX] = "LPUART_TX",

Done - but further refactoring should be done in 4.6 as we are in RC phase.

@ledvinap please approve if you are okay with the changes. We can refactor remaining items after release.

sugaarK · 2024-03-15T00:17:04Z

if this is am improvement not a bug fix it shouldn't be in 4.5. I use the lpuarts on my race builds on the airbot Fenix aios for the my elrs so I can use the provided plugs for my radio gear ( means I can have spare rx's ready to go ) it currently performs perfectly fine so this close to release would rather leave as is. I'd be a lot more comfortable with @DieHertz taking a look as he was behind the LPuart implementation, but he's still moving around a lot I thinks

haslinghuis · 2024-03-16T20:00:50Z

This PR fixes inconsistency between softserial and lpuart. Agree further improvements could be made in next version. Don't mind if this PR skips release as scope is limited. Rebased on master (for testing).

ctzsnooze · 2024-03-24T01:11:39Z

@haslinghuis
How should we test this one?

haslinghuis · 2024-03-24T17:35:36Z

@ctzsnooze You would need a board with LPUART

nerdCopter · 2024-03-25T15:37:25Z

only flashed, no real testing:

ctzsnooze

I'll approve on the basis that the only way to get wide testing is to get this into master. Seems that only G4 boards have LPUART. I don't have any of those.

* See betaflight#13567 (comment) * See betaflight#13306 (comment)

…#13568) * See #13567 (comment) * See #13306 (comment)

haslinghuis added the RN: IMPROVEMENT label Jan 17, 2024

haslinghuis self-assigned this Jan 17, 2024

haslinghuis force-pushed the add-lpuart-resource branch 2 times, most recently from 27ebbd2 to e39279f Compare January 18, 2024 00:26

ctzsnooze requested review from KarateBrot and SteveCEvans January 18, 2024 02:44

github-actions bot added the Inactive Automatically detected and labeled, will be closed after another week of inactivity. label Feb 17, 2024

haslinghuis removed the Inactive Automatically detected and labeled, will be closed after another week of inactivity. label Feb 17, 2024

haslinghuis added this to the 4.5 milestone Feb 18, 2024

haslinghuis requested review from DieHertz and ledvinap February 25, 2024 23:10

ledvinap reviewed Feb 26, 2024

View reviewed changes

haslinghuis requested review from KarateBrot and ledvinap and removed request for KarateBrot February 26, 2024 21:30

haslinghuis force-pushed the add-lpuart-resource branch from 74f2341 to bf082ff Compare March 10, 2024 22:26

haslinghuis added 3 commits March 16, 2024 21:14

Add resource for LPUART

14c2e15

Fix per review

d60892d

Fix per review 2

086788a

haslinghuis force-pushed the add-lpuart-resource branch from bf082ff to 086788a Compare March 16, 2024 20:15

nerdCopter approved these changes Mar 25, 2024

View reviewed changes

ctzsnooze approved these changes Mar 26, 2024

View reviewed changes

ledvinap approved these changes Mar 27, 2024

View reviewed changes

haslinghuis merged commit 9084128 into betaflight:master Mar 27, 2024

haslinghuis deleted the add-lpuart-resource branch March 27, 2024 08:57

hydra mentioned this pull request Apr 22, 2024

Configuration of LPUART is broken. #13567

Closed

hydra added a commit to hydra/betaflight that referenced this pull request Apr 22, 2024

Fix inability to use the CLI resource command to configure LPUART_RX.

46a1fcf

* See betaflight#13567 (comment) * See betaflight#13306 (comment)

nerdCopter mentioned this pull request Apr 22, 2024

Fix index and ability to configure LPUART_RX due to typo #13565

Merged

hydra added a commit to hydra/betaflight that referenced this pull request Apr 22, 2024

Fix inability to use the CLI resource command to configure LPUART_RX.

5b70720

* See betaflight#13567 (comment) * See betaflight#13306 (comment)

haslinghuis pushed a commit that referenced this pull request Apr 23, 2024

Fix inability to use the CLI resource command to configure LPUART_RX. (…

790fabc

…#13568) * See #13567 (comment) * See #13306 (comment)

Uh oh!

Add resource for LPUART #13306

Add resource for LPUART #13306

Uh oh!

Conversation

haslinghuis commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 17, 2024

Uh oh!

ctzsnooze commented Jan 18, 2024

Uh oh!

github-actions bot commented Feb 17, 2024

Uh oh!

HThuren commented Feb 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haslinghuis commented Feb 19, 2024

Uh oh!

HThuren commented Feb 20, 2024

Uh oh!

ledvinap Feb 26, 2024

Choose a reason for hiding this comment

Uh oh!

haslinghuis Feb 26, 2024

Choose a reason for hiding this comment

Uh oh!

ledvinap Feb 26, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ledvinap Feb 26, 2024

Choose a reason for hiding this comment

Uh oh!

haslinghuis Feb 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ledvinap Feb 26, 2024

Choose a reason for hiding this comment

Uh oh!

haslinghuis Feb 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haslinghuis Mar 26, 2024

Choose a reason for hiding this comment

Uh oh!

sugaarK commented Mar 15, 2024

Uh oh!

haslinghuis commented Mar 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ctzsnooze commented Mar 24, 2024

Uh oh!

haslinghuis commented Mar 24, 2024

Uh oh!

nerdCopter commented Mar 25, 2024

Uh oh!

ctzsnooze left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

haslinghuis commented Jan 17, 2024 •

edited

Loading

HThuren commented Feb 18, 2024 •

edited

Loading

haslinghuis Feb 26, 2024 •

edited

Loading

haslinghuis Feb 26, 2024 •

edited

Loading

haslinghuis commented Mar 16, 2024 •

edited

Loading