Do not return MSP_RESULT_ERROR when succesful #13328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to test this code? You can flash it directly from Betaflight Configurator:
WARNING: It may be unstable. Use only for testing! |
897d739 to
5611c1e
Compare
5611c1e to
71a4216
Compare
nerdCopter
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
- unable to test.
- approving as seems appropriate, but prefer @SteveCEvans to review.
ctzsnooze
approved these changes
Jan 30, 2024
|
Your change appears unrelated to your question. Your proposed change regarding not erroring a legitimate timer change looks good. This PR should be simple but the question makes it rather confusing! |
|
@SteveCEvans thank you for answering my question. Have removed it from the PR description. |
|
@SteveCEvans is this PR good to go now? |
SteveCEvans
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXIT_SUCCESSwould be better.Saw this issue while troubleshooting reboot into DFU issue on a H7.
To reproduce unsupported message error - change timer settings in OSD tab and save.