-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Increase ez_landing_limit default to 15 (was 5) #13375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase ez_landing_limit default to 15 (was 5) #13375
Conversation
Do you want to test this code? You can flash it directly from Betaflight Configurator:
WARNING: It may be unstable. Use only for testing! |
@tbolin having a conservative default is good. Like to include this PR asap. |
I'd like to add on a 10 inch. When I do a full throttle punch out and drop throttle to zero. My quad does a nose dive like I pitched forward. It scared me the first few times. If I drop throttle to even 1-5% it doesn't happen. |
First: Check that airmode is always on. If airmode is on: Please post a log when the dives happen, and also one (or the same log) where you raise throttle a bit and they do not. The diving behavior is not surprising with a bigger quad and ez_landing_limit at 5. If airmode is off, the diving is also expected, even with the legacy mixer type |
I finally have a quad that should be bouncy enough to be representative for most. If that thing does not bounce at 15 it should be fine for the majority of quads, especially those flown by inexperienced users that could have trouble handling bouncing and changing settings. I will test later today and if everything is fine I will mark the PR as ready. |
Bounce test completed. |
There has been reports of instability when using EzLanding with the default ez_landing_limit of 5.
Especially freestyle quads with action cameras appear to have problems.
For example
https://youtube.com/clip/Ugkx-I6x2nW888n3OSC91ISli89JiUwHw-w-?si=s5hrpcZgTIUDIOyH
https://github.com/betaflight/betaflight/assets/6018638/0fd02995-2bc3-4d89-9576-a44ad282274f
ez_landing_instability_logs.zip
Increasing ez_landing_limit have fixed the instability without noticeably increasing bounciness in at least one case.
The current ez_landing_limit is also known to be pretty conservative.
In theory 15 should still be less bouncy (with sticks centered and throttle at zero) than airmode off with the LEGACY mixer_type, and provide a bit more stability during dives.
More testing on different types of quad is still required though.
Thanks to DrainMan FPV for the first video and reptethetetlen for the second video and logs.