fix at32 serial bidir pp od init and smart audio #13764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to test this code? You can flash it directly from Betaflight Configurator:
WARNING: It may be unstable. Use only for testing! |
ledvinap
approved these changes
Jul 11, 2024
src/main/io/vtx_smartaudio.c
Outdated
| @@ -497,6 +497,7 @@ static void saReceiveFrame(uint8_t c) | |||
| static void saSendFrame(uint8_t *buf, int len) | |||
| { | |||
| if (!IS_RC_MODE_ACTIVE(BOXVTXCONTROLDISABLE)) { | |||
| #ifndef AT32F4 | |||
There was a problem hiding this comment.
Suggested change
| #ifndef AT32F4 | |
| #ifndef AT32F4 |
Also, at this level, AT32F4 should be identical to STM32 cpus; This will result in different protocol and AT32F4.
It almost looks like there are different bugs in smartaudio, dependent on version, and each developer adjusts his own CPU version accordingly ...
There was a problem hiding this comment.
i understand that the STM32 chips will always pull the line high before transmitting a byte, making the this dummy byte necessary. i could be wrong tho, maybe @freasy can elaborate.
include fix for F4 and G4 as well
|
Applied formatting suggestions, squashed and rebased. |
blckmn
approved these changes
Jul 15, 2024
haslinghuis
approved these changes
Jul 15, 2024
haslinghuis
pushed a commit
to haslinghuis/betaflight
that referenced
this pull request
Jul 16, 2024
include fix for F4 and G4 as well Co-authored-by: Eike Ahmels <ea@weslink.de>
haslinghuis
added a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originally submitted as #13663,
cherry picked the original commits on top of master.