Skip to content

OSD background rendering #13897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2024
Merged

OSD background rendering #13897

merged 2 commits into from
Sep 13, 2024

Conversation

SteveCEvans
Copy link
Member

Fixes the issue mentioned in #13813 (comment)

There were two issues with rendering the craft and pilot name. Note that these are considered background items.

  1. On Walksnail the attribute of the previous foreground items were picked up which could result in the wrong colour or even flashing.
  2. The MAX7456 doesn't support a background layer, but the MAX7456 driver claimed that it does.

@SteveCEvans SteveCEvans self-assigned this Sep 11, 2024
@github-actions GitHub Actions
Copy link

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #13897 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@SteveCEvans SteveCEvans mentioned this pull request Sep 11, 2024
Merged
@haslinghuis haslinghuis added this to the 4.6 milestone Sep 12, 2024
nerdCopter
nerdCopter approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving untested

@haslinghuis haslinghuis merged commit 73b2616 into betaflight:master Sep 13, 2024
27 checks passed
haslinghuis pushed a commit to haslinghuis/betaflight that referenced this pull request Sep 13, 2024
@SteveCEvans @haslinghuis
OSD background rendering (betaflight#13897)
a8dd676 
* Ensure display severity attribute is set to defaults for background items

* MAX7456 doesn't have a background layer
@haslinghuis haslinghuis mentioned this pull request Sep 13, 2024
Merged
haslinghuis added a commit that referenced this pull request Sep 13, 2024
@haslinghuis @SteveCEvans
[4.5.2] OSD background rendering (#13897) (#13900)
cfdcf57 
OSD background rendering (#13897)

* Ensure display severity attribute is set to defaults for background items

* MAX7456 doesn't have a background layer

Co-authored-by: Steve Evans <SteveCEvans@users.noreply.github.com>
@elhsmart
Copy link

@SteveCEvans this commit broke OSD rendering with MAX7456 if OSD_RSSI_VALUE element is present on the screen. What do I need to provide to raise a bug about this? Sorry, I'm newbie in community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ledvinap ledvinap ledvinap approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@blckmn blckmn Awaiting requested review from blckmn

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

Assignees

@SteveCEvans SteveCEvans

Labels
RN: BUGFIX Tested
Projects
Finalizing Firmware 4.6 Release
Status: Done
Milestone
4.6
Development

Successfully merging this pull request may close these issues.
5 participants
@SteveCEvans @elhsmart @ledvinap @haslinghuis @nerdCopter