Don't consider a prior I2C NACK to indicate the bus to be busy #13917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to test this code? You can flash it directly from Betaflight Configurator:
WARNING: It may be unstable. Use only for testing! |
blckmn
approved these changes
Sep 21, 2024
haslinghuis
approved these changes
Sep 22, 2024
KarateBrot
approved these changes
Sep 22, 2024
haslinghuis
pushed a commit
to haslinghuis/betaflight
that referenced
this pull request
Sep 22, 2024
|
@SteveCEvans: What happens when other error is detected during baro discovery? It will make that bus unusable? No reset/retry ? |
|
@ledvinap Not exactly graceful recovery, but the other errors aren’t expected unless there’s actually a hardware problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AT32F435 targets if USE_MAG is defined to support an external compass but it's not present then the probe for the magnetometer would terminate with the I2C bus error code reporting
I2C_ERR_ACKFAIL.As this was not
I2C_OKthe bus was then considered busy and any subsequent access on that bus, to for example a barometer, would be blocked.This should not be taken to indicate that the bus is busy as the last I2C transaction terminated correctly and the bus is available for the next access.