Skip to content

AT32F435 SD card support #14018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

SteveCEvans
Copy link
Member

Define either USE_FLASH or USE_SDCARD to support FLASH or SDCARD on AT32F435.

Copy link

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #14018 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@haslinghuis haslinghuis added this to the 4.6 milestone Nov 11, 2024
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: reset my approval as I saw comments that SDCard not yet working.

@nerdCopter nerdCopter self-requested a review November 12, 2024 15:45
@SteveCEvans
Copy link
Member Author

See #14070. Rebase after that is merged.

@haslinghuis
Copy link
Member

Now #14070 fixed SDC for AT32 it is shown in either setting (flash / sdc)

  • only one blackbox device can be active at the time - will this restrict having both FLASH and SDCARD (so we can switch between) ?

image

@SteveCEvans
Copy link
Member Author

You’ll need to build with USE_FLASH or USE_SD_CARD

@haslinghuis
Copy link
Member

Okay, but ORBITF435 has both options available

@orbittechnologyx
Copy link

Hi @haslinghuis, @SteveCEvans
I applied your code changes in this PR and built it with both USE_FLASH and USE_SD_CARD defined in the configuration. This allowed me to select either the SD card or Flash as the blackbox. However, I noticed that when the blackbox is set to the SD card and I switch to MSC mode, the computer doesn't recognize the SD card. On the other hand, it works fine in Flash mode.

@haslinghuis
Copy link
Member

Guess this needs a rebase to include #14070

@haslinghuis
Copy link
Member

@SteveCEvans please rebase

@SteveCEvans
Copy link
Member Author

Rebase done, but still needs work.

@SteveCEvans
Copy link
Member Author

Now working and reporting both FLASH and SD card capacity and either can be selected.

image

With Onboard Flash selected that Blackbox tab displays the available capacity for both the onboard flash and the SD, but shows the capacity of the SD card in the page header. I think it should report the flash capacity in this case. Anyway the ORBITF435 is now working.

@nerdCopter
Copy link
Member

backport to 4.5.x needed?

@blckmn
Copy link
Member

blckmn commented Jan 2, 2025

backport to 4.5.x needed?

@haslinghuis please let @SteveCEvans do the back porting

@haslinghuis haslinghuis merged commit b1604e8 into betaflight:master Jan 2, 2025
27 checks passed
SteveCEvans added a commit to SteveCEvans/betaflight that referenced this pull request Jan 3, 2025
blckmn pushed a commit that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants