Skip to content

Fix missing GPS Laptimer OSD elements #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix missing GPS Laptimer OSD elements #3506

merged 1 commit into from
Jul 18, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jul 9, 2023 •
edited by nerdCopter
Loading

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jul 9, 2023
@haslinghuis haslinghuis self-assigned this Jul 9, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member Author

@SpencerGraffunder please check

@blckmn
Copy link
Member

blckmn commented Jul 10, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@SpencerGraffunder
Copy link

SpencerGraffunder commented Jul 10, 2023 •
edited by nerdCopter
Loading

https://discord.com/channels/868013470023548938/1019022739044057128/1116834722191003658

If someone else could officially add, that would be great. I won’t have time for a few weeks.

image

@haslinghuis
Copy link
Member Author

image

@SpencerGraffunder
Copy link

lap_timer_mcm.zip

@nerdCopter
Copy link
Member

@SpencerGraffunder , any font changes would have to be done to all font variations. Also, vendors already flash "default" font. All pilots would need to update to use any new changes.
image
fonts have been stable for no less than 4 years: https://github.com/betaflight/betaflight-configurator/tree/master/resources/osd/2

not opposed to changes, just informing.

@haslinghuis haslinghuis merged commit dfd12cd into betaflight:master Jul 18, 2023
@haslinghuis haslinghuis deleted the fix-missing-osd-elements branch July 18, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmelevskij chmelevskij chmelevskij approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @blckmn @SpencerGraffunder @nerdCopter @chmelevskij