Skip to content

Remove event listener for flashing using Enter key. #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2024
Merged

Remove event listener for flashing using Enter key. #3804

merged 2 commits into from
Feb 20, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Feb 16, 2024 •
edited
Loading

When using autocomplete the background does not observe darkmode. Also on enter to accept the field it triggers firmware flashing.

This PR

  • disables autocomplete for the custom define field
  • removes the keypress for flashing

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Feb 16, 2024
@haslinghuis haslinghuis self-assigned this Feb 16, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@nerdCopter
Copy link
Member

Well, i have made use of the autocomplete on occasion. However, the Enter key is certainly a problem.

HThuren
HThuren approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@HThuren HThuren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, now no autocomplete and Enter are disabled here (and not in other fields)

@haslinghuis
Copy link
Member Author

@nerdCopter - you can still paste in text

@nerdCopter
Copy link
Member

@nerdCopter - you can still paste in text

understood. but easier when i don't have to search the settings 😆 .
i think it is this css, if i'm not mistaken:
image

@haslinghuis
Copy link
Member Author

Could not find a[n easy] way in a hour to override the user agent style

@HThuren
Copy link
Member

HThuren commented Feb 16, 2024

Could not find a[n easy] way in a hour to override the user agent style

I'm not sure what you want to solve?

@haslinghuis
Copy link
Member Author

Trying to keep autocomplete - not messing with dark mode

@HThuren
Copy link
Member

HThuren commented Feb 17, 2024

I have no experience here, but maybe change in js, ie. $('input').attr('autocomplete','on');

@nerdCopter
Copy link
Member

Trying to keep autocomplete - not messing with dark mode

if you make this PR only about the enter key, then i can approve. then the less-important theming could be separate/later/

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@haslinghuis haslinghuis changed the title Disable autocomplete on custom defines field Remove event listener for flashing using Enter key. Feb 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit da1e142 into betaflight:master Feb 20, 2024
@haslinghuis haslinghuis deleted the fix-custom-defines-input branch February 20, 2024 14:06
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Remove event listener for flashing using Enter key. (betaflight#3804)
5726a4d 
* Disable autocomplete on custom defines field

* Keep autocomplete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@HThuren HThuren HThuren approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@haslinghuis @nerdCopter @HThuren