Added option Arming without fix to GPS Rescue #256
Conversation
Depends on what you want. If you bump it the page won't be shown if the flight controller reports a version older than this. So in your case it is probably safe and better to not bump it. |
|
@kaweksl: This needs to be rebased. |
src/SCRIPTS/BF/PAGES/rescue.lua
Outdated
| minBytes = 16, | ||
| requiredVersion = 1.041, | ||
| minBytes = 21, | ||
| requiredVersion = 1.043, |
There was a problem hiding this comment.
Seeing that we had a lot of improvements in the lua scripts since the last release, and will probably want to do another release before Betaflight 4.2 (which will bring API version 1.43) is released, I'd rather leave this at 1.041 for now - obviously the 'arming without fix' setting won't work for users before Betaflight 4.2, but at least they will still be able to use the rest of the GPS rescue page.
There was a problem hiding this comment.
but increased minBytes won't cause problems if script will not receive 21 bytes ?
UPDATE:
I have checked this with X9D+ , BF 4.1 and with requiredVersion 1.041, rescue page doesn't work.
UPDATE:
looks like minBytes at 16 and requiredVersion at 1.041 is working with BF 4.1 and 4.2.
had impression that increasing minBytes is mandatory
|
GPS rescue is starting to get a little cramped 😄 @kaweksl May I suggest laying out GPS rescue like PID Advanced? Maybe using that as a template? |
|
By like in PID Advanced You mean all settings in a single column? |
|
@kaweksl Yes. That way we could maybe fit |
|
Yep, that would make things more readable on X7. Just wonder if do that on other radios/resolutions |
|
It doesn't hurt to have the same layout across all radios IMO. It's done like that for some of the other pages like PID advanced and filters. |
|
@kaweksl: Let me know if you want to change the layout on this pull request. Apart from that this is ready for merge now. |
|
@mikeller I wanted but i'm having an issue with scrolling, looks like there is limit for how much you can scroll. So for now i just made cosmetics changes. Do you want me to squash PR ? |
|
Na, it's fine, thanks. |
Sometimes you just wanna fly immediately/under roof
Requires changes in betaflight ( betaflight/betaflight#9026 )
Someone has to adjust text position for nirvana as I don't have it and there is no simulator available.
requiredVersion should be bumped ?