Skip to content

Conversation

frozenskys
Copy link
Contributor

Fixes a couple of issues after the refactor to common pages...

mikeller
mikeller previously approved these changes Oct 21, 2019
@mikeller mikeller added this to the 1.5 milestone Oct 21, 2019
@frozenskys
Copy link
Contributor Author

@mikeller been thinking about the api required version (as I think we will need to change this for vtx_tables.) Does it still make sense to do it at a page level - or would it be best to pull it up to a script level and give an error if the version is mismatched?

@mikeller
Copy link
Member

@frozenskys: Not sure. Doing version checking at page level is convenient, as it allows the scripts to support (limited) backwards compatibility. If we do it at the script level then bugfixes and non-MSP-related improvements (like the new top level menu) will not become available to users of older firmware unless we backport them and do maintenance releases for older script versions.
But if version checking at page level gets too complicated / runs into memory constraints, then doing it at script level will be a way out.

@mikeller mikeller merged commit fd352e5 into betaflight:master Oct 23, 2019
@frozenskys frozenskys deleted the fixes-after-refactor branch October 23, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants