More memory savings #285
Merged
More memory savings #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
previously approved these changes
Nov 12, 2019
6657ba0 to
94e6dbc
Compare
mikeller
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some unused variables.
Made global variables in msp related files local as they don't have to be global.
Made
getProtocol()a local function.Have tested it and it works.
Looks like it saves about 1.5-2k of memory.
Edit:
Made
payloadlocal tosaveSettings(). We don't need access to it outside of this function. This reduces the memory spike when saving and preventspayloadfrom sticking around after saving.