Unload background when not used + other minor changes #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
previously approved these changes
Dec 9, 2019
Unloads background when ui is visible. It's prevented from running anyway. Removed optional init function. + some minor simplifications. Saves around 2KB for telemetry script. Reference tables instead of copying No need to make actual copies of these tables. Saves a little bit of memory and some cpu cycles. Separate main menu event handling from draw code Rename incLine to incField incValue fix Avoid potential nil divided by scale if for some reason min/max doesn't exist. Make ui.lua functions local They're only used in this file
beda28b to
d354232
Compare
mikeller
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unloads background when ui is visible. It's prevented from running anyway.
Removed optional init function.
+some minor simplifications.Saves around 2KB for telemetry script.
This means that
backgroundwill redetectapiVersionand set the time when it's loaded again. But that's ok IMO.Also separated event handling from lcd draw code for the main menu.
+some other minor changes.Have tested this and everything works as it should.