Fix TEXT_COLOR bug + other fixes #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TEXT_COLOR is not a thing on the radios with low resolution screen.
mikeller
previously approved these changes
Dec 13, 2019
Needed by vtx page
This is old code. i is not used anymore and currentField is not the index for the values we want to edit.
mikeller
approved these changes
Dec 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEXT_COLOR is not a thing on the radios with low resolution screen.
When trying to load the script on one of these radios it won't work as it tries to perform arithmetic on a nil value.
It worked in earlier versions because
NoTelemwas in the pre.lua file for each radio. Now it's all in the same table that is loaded for all radios.Bug introduced in #295. My mistake. Sorry
EDIT:
Made
clipValueglobal again. Used by VTX page. Was sure I did agit grepbut apparently not.Added commit to fix the
Page.valuescheck before entering editing state.This is old code.
iis not used anymore andcurrentFieldis not the index for the values we want to edit.