Improve protocol detection #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From OpenTX 2.3.4 sport/crossfireTelemetryPush behaviour is changed. These functions will now return nil if incorrect telemetry protocol is detected.
mikeller
approved these changes
Dec 23, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From OpenTX 2.3.4 sport/crossfireTelemetryPush behaviour is changed.
These functions will now return nil if incorrect telemetry protocol is detected.
opentx/opentx#7229
This should get rid of "script syntax error telemetry protocol not supported" if it's caused by the buffer not being available when the telemetryPush functions are called. This allows scripts that do protocol detection like BF lua to reliably start even if some other script has put something in the buffer.
OpenTX 2.3.4 is a requirement for this to work. It was just released https://github.com/opentx/opentx/releases/tag/release%2F2.3.4