Remove Gyro/PID loop #335
Merged
Remove Gyro/PID loop #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
reviewed
May 4, 2020
src/SCRIPTS/BF/PAGES/pwm.lua
Outdated
| @@ -37,9 +37,12 @@ if apiVersion >= 1.031 and apiVersion <= 1.040 then | |||
| fields[#fields + 1] = { t = "32kHz Sampling", x = x, y = inc.y(lineSpacing), sp = x + sp, min = 0, max = 1, vals = { 9 }, table = { [0] = "OFF", "ON" }, upd = function(self) self.updateRateTables(self) end } | |||
| end | |||
|
|
|||
| if apiVersion >= 1.016 then | |||
| if apiVersion >= 1.016 and apiVersion <= 1.042 then | |||
There was a problem hiding this comment.
<nitpick>
Tiny little bit cleaner with:
if apiVersion >= 1.016
if apiVersion <= 1.042 then
 fields[#fields + 1] = { t = "Gyro Update", x = x, y = inc.y(lineSpacing), sp = x + sp, min = 1, max = 32, vals = { 1 }, table = {}, upd = function(self) self.updatePidRateTable(self) end }
 fields[#fields + 1] = { t = "PID Loop", x = x, y = inc.y(lineSpacing), sp = x + sp, min = 1, max = 16, vals = { 2 }, table = {} }
end

[...]
</nitpick>
5d70ae4 to
6e2d352
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mikeller
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for Betaflight 4.2 and up. With gyro native rate sampling these numbers will only make sense for gyros with 8kHz sampling rate.