Skip to content

Battery page: Fix battery capacity steps, changed max capacity to 20000 #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2025
Merged

Battery page: Fix battery capacity steps, changed max capacity to 20000 #525

merged 1 commit into from
Aug 10, 2025
+1 −1

Conversation

Forceu
Copy link
Contributor

@Forceu Forceu commented Aug 10, 2025 •
edited by coderabbitai bot
Loading

As requested in #522, this PR fixes the step value.
I also changed the max capacity to 20Ah instead of 10.

Summary by CodeRabbit

  • Enhancements
    • Increased the maximum value for the "Battery Capacity" field from 10,000 to 20,000.
    • Adjusted the value increment for "Battery Capacity" to use a multiplicative factor of 25.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 10, 2025 •
edited
Loading

Walkthrough

The configuration for the "Battery Capacity" field in the battery settings page was updated. The step size parameter was replaced with a multiplicative factor, and the maximum allowed value was increased from 10,000 to 20,000. No other fields or logic were changed.

Changes

Cohort / File(s) Change Summary
Battery Capacity Field Update
src/SCRIPTS/BF/PAGES/battery.lua		 Changed "Battery Capacity" field: replaced steps = 25 with mult = 25, and increased max from 10,000 to 20,000.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BatteryPage (battery.lua)
    User->>BatteryPage: Adjusts "Battery Capacity"
    BatteryPage-->>User: Presents values in increments of 25, up to 20,000
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • haslinghuis

Poem

A hop and a skip, a tweak in the code,
Battery numbers now double their load!
Steps become multiples, scaling anew,
For pilots and bunnies, more mAh to view.
With every new charge, we leap with delight—
The battery page now feels just right!
🐇🔋

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 528dbff and 49ea1ae.

📒 Files selected for processing (1)
  • src/SCRIPTS/BF/PAGES/battery.lua (1 hunks)
🔇 Additional comments (2)
src/SCRIPTS/BF/PAGES/battery.lua (2)

20-20: Max capacity to 20,000 mAh looks good

Matches the PR goal, fits within 16-bit storage for vals={4,5}, and 20000 is divisible by 25 (clean stepping).

20-20: Confirmed ‘mult’ is step increment only (no unintended scaling)

  • UI logic (src/SCRIPTS/BF/ui.lua 243–244) uses f.mult purely as the edit-step delta; f.scale governs any unit conversion.
  • There are no step= or steps= properties anywhere in src/SCRIPTS/BF.
  • The Battery Capacity field (src/SCRIPTS/BF/PAGES/battery.lua 20) omits scale, so its max=20000 and mult=25 operate directly on raw mAh values.
  • No other pages rely on a nonexistent steps key.

→ No changes required.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Forceu Forceu mentioned this pull request Aug 10, 2025
Merged
@haslinghuis haslinghuis added this to the 1.8 milestone Aug 10, 2025
@haslinghuis haslinghuis merged commit c0eb63a into betaflight:master Aug 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@Forceu @haslinghuis