-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Add FullscreenMaterial #20414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add FullscreenMaterial #20414
Conversation
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
b0f9763
to
70e61bd
Compare
As a 2D user, when I first read “ I’d lean into the |
I disagree the main goal of this api is to be a general purpose fullscreen render pass. The main feature is that it can be inserted in any order because some people don't want a post process effect, they just want to do something like render their entire game in a fullscreen shader in the main pass. Like I mentioned in the notes. A post processing version of this would be built on top of the same api but with pre configured ordering. |
Objective
Solution
Testing
Made a new fullscreen_material example and made sure it works
Follow up
Once this is merged there are various things that should be done to improve it. Add the option to bind the depth texture, offer defaults for post processing, use a full AsBindGroup, add a way to bind the gbuffer.