Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Make it possible to customise the port the dashboard connects to #124

Merged
merged 7 commits into from
Sep 4, 2019

Conversation

eldor
Copy link
Contributor

@eldor eldor commented Mar 1, 2019

This merge will make it possible to customise what port the dashboard connects to.

At our place we have a dedicated WS server that serves websockets over 80/443 therefor it would be nice to be able to change the port i config.

@miks
Copy link

miks commented Mar 7, 2019

Any ETA left for this to merge? We also are having issues while serving wss over nginx with ssl.
@eldor can you please also add wsPath for this merge request?

@eldor
Copy link
Contributor Author

eldor commented Mar 7, 2019

Hi @miks i have added wsPath to the Pusher config (not tested)
I'm sure that @mpociot will look into this merge when he have the time, so just have patience.

@bgarrison25
Copy link

So, its been a month and was just wondering if this was going to get pulled in. We need the same thing over here

@mpociot
Copy link
Member

mpociot commented May 11, 2019

Hi @eldor

thank you for this PR - and for the patience :)
I am not really happy with the naming of the config keys, as this might be a bit misleading/confusing.

First of all, these are (to my knowledge) not default pusher settings. So prefixing these environment variables with PUSHER_ might be wrong.

Why are the port keys inside the apps array? Can two apps use two different ports and paths?

Wouldn't it be sufficient to have a generic port/path config under a new dashboard setting inside the configuration file?

@eldor
Copy link
Contributor Author

eldor commented May 21, 2019

Hi @mpociot

You are right, I have moved it into dashboard section in config and renamed the env name to DASHBOARD_PORT

@jonnywilliamson
Copy link

Would love to see this pulled in. Have a WS server that is NOT served at / and so I am desperate to get the wsPath config value added!

Thank you!

@mpociot mpociot merged commit 8e422cb into beyondcode:master Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants